Switch to 2024 edition #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The migration tool automatically changed some of thcode causing some
churn. I manually changed some of the things, like removing expr_2021
from macros as it was not necessary and changing the renaming of the now
reserved word gen from r#gen to generator.
A bunch of let Some() {} else () expressions were changed to matches, I
let that be, sometime smatch turns out to be idiomatic, sometimes it is
about the same readability.
Signed-off-by: Simo Sorce <[email protected]>
Jakuje
approved these changes
Mar 13, 2025
Contributor
Jakuje
left a comment
Jakuje
left a comment
There was a problem hiding this comment.
lgmt. I find the matches most of the time easier to read than the if let Ok() ... constructs, but at some when there is a lot of code inside, they end up too indented ...
Contributor
|
Should the edition be changed also in Cargo.toml ? https://github.com/latchset/kryoptic/blob/main/Cargo.toml#L4 |
Member
Author
Well, I am confused, the migration is really about changing it in Cargo.toml which is how I started it ... I am really surprised the MR did not end up having it there, without the Cargo.toml change no change really happened. I will open a followup change to actually do the change then. |
Member
Author
|
Filed #187 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The migration tool automatically changed some of thcode causing some churn. I manually changed some of the things, like removing expr_2021 from macros as it was not necessary and changing the renaming of the now reserved word gen from r#gen to generator.
A bunch of let Some() {} else () expressions were changed to matches, I let that be, sometime smatch turns out to be idiomatic, sometimes it is about the same readability.
Checklist
Test suite updated with functionality testsTest suite updated with negative testsDocumentation was updatedThis is not a code changeReviewer's checklist: