Fix incorrect error returned on un-initialized operations #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an operation is not initialized we need to return the CKR_OPERATION_NOT_INITIALIZED and not CKR_GENERAL_ERROR, this is a regression from a recent change. Fixes latchset#191 Signed-off-by: Simo Sorce <[email protected]>
Jakuje
approved these changes
Mar 31, 2025
Contributor
Jakuje
left a comment
Jakuje
left a comment
There was a problem hiding this comment.
just typo and formatting. Otherwise lgtm
src/tests/session.rs
Outdated
| }; | ||
|
|
||
| /* Ensure that trying to call an operation w/o initialization returns | ||
| * the propoer error |
Contributor
There was a problem hiding this comment.
Suggested change
| * the propoer error | |
| * the proper error |
Signed-off-by: Simo Sorce <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #191
Checklist
[ ] Documentation was updated[ ] This is not a code changeReviewer's checklist: