Ensure token store objects can be extracted if the right booleans are set

[simo5]

Description

The database optimized code was not sourcing the CKA_SENSITIVE/CKA_EXTRACTABLE attributes for token objects, this would cause subsequent checks on these attributes to use the object defaults rather than what was actually stored.
Session objects did not suffer from this issue because all attributes are always available for those.

Fixes: #193

Checklist

• Test suite updated with functionality tests
• Test suite updated with negative tests
• [ ] Documentation was updated
• [ ] This is not a code change

Reviewer's checklist:

• Any issues marked for closing are fully addressed
• There is a test suite reasonably covering new functionality or modifications
• This feature/change has adequate documentation added
• A changelog entry is added if the change is significant
• Code conform to coding style that today cannot yet be enforced via the check style test
• Commits have short titles and sensible text

[Jakuje]

you were faster :)
lgtm. I just wanted to make sure we do not need some more in different code paths, but that can be done later if needed.

[simo5]

you were faster :) lgtm. I just wanted to make sure we do not need some more in different code paths, but that can be done later if needed.

Reasonably confident this is all we need, but we can always add more patches later indeed.

Thanks for the review and all these bugs, each fix make kryoptic more robust and compliant, which I like.

[Jakuje]

Thinking if this is the right place to add these though. In get_object_attrs() we are adding already different attributes for the non-logged in users. I think that would be probably better place ...

[simo5]

Thinking if this is the right place to add these though. In get_object_attrs() we are adding already different attributes for the non-logged in users. I think that would be probably better place ...

No, this is the correct place, the one you see in get_objects_attr() is only for the case where a user is not logged in and mixing the use cases would be confusing.

[Jakuje]

Ok. Went through the places where else we fetch the data from db and this is the only one where we missed something, I think.