Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): install module with delegation #3586

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

feat(cli): install module with delegation #3586

wants to merge 19 commits into from

Conversation

holic
Copy link
Member

@holic holic commented Feb 6, 2025 •
edited
Loading

fixes #3569

TODO

  • fix encodeSystemCalls and encodeSystemCallsFrom types or revert
  • add tests

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: f38cd84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – explorer February 6, 2025 23:10 Inactive
@vercel vercel bot temporarily deployed to Preview – explorer February 7, 2025 00:44 Inactive
@vercel vercel bot temporarily deployed to Preview – explorer February 7, 2025 00:47 Inactive
@vercel vercel bot temporarily deployed to Preview – explorer February 7, 2025 00:59 Inactive
holic
holic commented Feb 7, 2025
View reviewed changes
packages/store/ts/getStoreLogs.test.ts
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so cool to see the delegation in action via these store log changes for the mock game contracts

@holic holic marked this pull request as ready for review February 7, 2025 01:05
@holic holic requested a review from alvrs as a code owner February 7, 2025 01:05
@vercel vercel bot temporarily deployed to Preview – explorer February 7, 2025 01:09 Inactive
@holic holic force-pushed the holic/module-delegation branch from bce9b86 to a681215 Compare February 7, 2025 11:22
@vercel vercel bot temporarily deployed to Preview – explorer February 7, 2025 11:22 Inactive
@holic holic mentioned this pull request Feb 7, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvrs alvrs Awaiting requested review from alvrs alvrs is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add option to register delegation during module install
1 participant
@holic