Skip to content

Commit

Permalink
Validate package.json imports.
Browse files Browse the repository at this point in the history
  • Loading branch information
kinyoklion committed Sep 11, 2024
1 parent a9ae9ac commit fd8d7d6
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 18 deletions.
2 changes: 1 addition & 1 deletion packages/sdk/browser/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
"devDependencies": {
"@launchdarkly/private-js-mocks": "0.0.1",
"@rollup/plugin-commonjs": "^25.0.0",
"@rollup/plugin-json": "^6.1.0",
"@rollup/plugin-node-resolve": "^15.0.2",
"@rollup/plugin-terser": "^0.4.3",
"@rollup/plugin-typescript": "^11.1.1",
Expand All @@ -59,7 +60,6 @@
"prettier": "^3.0.0",
"rimraf": "^5.0.5",
"rollup": "^3.23.0",
"rollup-plugin-generate-package-json": "^3.2.0",
"ts-jest": "^29.1.1",
"typedoc": "0.25.0",
"typescript": "^5.5.3"
Expand Down
18 changes: 3 additions & 15 deletions packages/sdk/browser/rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import common from '@rollup/plugin-commonjs';
import resolve from '@rollup/plugin-node-resolve';
import terser from '@rollup/plugin-terser';
import typescript from '@rollup/plugin-typescript';
import generatePackageJson from 'rollup-plugin-generate-package-json';
import json from '@rollup/plugin-json';

const getSharedConfig = (format, file) => ({
input: 'src/index.ts',
Expand All @@ -24,13 +24,6 @@ export default [
{
...getSharedConfig('es', 'dist/index.es.js'),
plugins: [
generatePackageJson({
baseContents: (pkg) => ({
name: pkg.name,
version: pkg.version,
type: 'module',
}),
}),
typescript({
module: 'esnext',
}),
Expand All @@ -40,22 +33,17 @@ export default [
}),
resolve(),
terser(),
json(),
],
},
{
...getSharedConfig('cjs', 'dist/index.cjs.js'),
plugins: [
generatePackageJson({
baseContents: (pkg) => ({
name: pkg.name,
version: pkg.version,
type: 'commonjs',
}),
}),
typescript(),
common(),
resolve(),
terser(),
json(),
],
},
];
5 changes: 3 additions & 2 deletions packages/sdk/browser/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import BrowserInfo from './platform/BrowserInfo';
import DefaultBrowserEventSource from './platform/DefaultBrowserEventSource';

// Temporary exports for testing the events source in a browser.
export { DefaultBrowserEventSource };
// Temporary exports for testing in a browser.
export { DefaultBrowserEventSource, BrowserInfo };
export * from '@launchdarkly/js-client-sdk-common';

export function Hello() {
Expand Down

0 comments on commit fd8d7d6

Please sign in to comment.