chore: Add Detox e2e tests for RN SDK. #376
Conversation
yusinto
requested review from
kinyoklion and
louis-launchdarkly
as code owners
|
This pull request has been linked to Shortcut Story #228487: Detox in CI. |
| "detox-build-ios": "detox build -c ios.sim.release", | ||
| "detox-run-ios": "detox test -c ios.sim.release --cleanup --headless", |
There was a problem hiding this comment.
Use release builds for e2e tests instead of debug builds.
| @@ -12,11 +17,5 @@ yarn expo-prebuild | |||
| echo "===== Delete .xcode.env.local" | |||
| rm -rf ./ios/.xcode.env.local | |||
|
|
|||
| echo "===== Start metro in background" | |||
| yarn start & | |||
|
|
|||
There was a problem hiding this comment.
Metro no longer needed in release builds when running e2e.
| <ScrollView style={{ flexGrow: 0.2, backgroundColor: 'black', maxHeight: 200 }}> | ||
| <Text style={{ color: 'orange' }}>Logging: {JSON.stringify(context, null, 2)}</Text> | ||
| </ScrollView> |
There was a problem hiding this comment.
Replace Text with a ScrollView so ui elements don't shift when the json string gets displayed. The shitfing affects UI elements positioning and hence tapping/clicking fails.
| }, | ||
| "packageManager": "[email protected]", | ||
| "installConfig": { | ||
| "hoistingLimits": "workspaces" |
There was a problem hiding this comment.
Force example app to use its own copies of deps, except for @launchdarkly/* deps. Without this, different versions of the a package like event-target-shim will conflict and result in cryptic metro compilation errors.
|
@kinyoklion @louis-launchdarkly This also fixes the RN SDK example app which is broken right now because of conflicting monorepo versions of |
Runs e2e tests for iOS. Android will follow in a separate PR. Only contains basic eval and variation tests right now.