Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin jsonc-parser to fix cloudflare rollup build. #485

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

yusinto
Copy link
Contributor

@yusinto yusinto commented Jun 24, 2024

Seems like v3.3.0 of jsonc-parser causes an error in rollup-plugin-esbuild:

[!] SyntaxError: Named export 'parse' not found. The requested module 'jsonc-parser' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from 'jsonc-parser';
const { parse } = pkg;

/js-core/node_modules/rollup-plugin-esbuild/dist/index.mjs:11
import { parse } from "jsonc-parser";
         ^^^^^

@yusinto yusinto requested a review from a team June 24, 2024 16:27
@yusinto yusinto enabled auto-merge (squash) June 24, 2024 17:27
@yusinto yusinto merged commit 5f681fe into main Jun 24, 2024
20 checks passed
@yusinto yusinto deleted the yus/sc-248139/fix-cloudflare-rollup-build-dependency branch June 24, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants