chore: Build releases in dependency order. #563
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains several conditions that appear to be illogical, but are required by github actions. For some background this issue can be read:
actions/runner#491
always()
:Imagine two packages. Package "a" and package "b".
"b" depends on "a" and we want to automatically release "a" and "b" using release please. We make "b"
needs
"a", so that "b" will build after "a". But if we do that, then "b" will not build unless "a" also builds. We often need to release "b" even though there are no changes to "a".By using
if: always()
we can cause "b" to run after "a" even when "a" doesn't run.failure()
andcanceled()
.With
always()
package "b" will be built and released even if package "a" failed to build. You would expect that to only requirefailure()
, but it seems that it only works if you havecanceled()
as well. (It may be we don't actually need failure.)We want the build order to be like this.
