-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Replace prefetch behavior with simple TTL cache #786
Open
keelerm84
wants to merge
6
commits into
main
Choose a base branch
from
mk/sdk-1075/json-decoding
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@launchdarkly/js-sdk-common size report |
@launchdarkly/js-client-sdk-common size report |
@launchdarkly/js-client-sdk size report |
Previously, the LDClient would issue a call to prime the store with data, which would be retained for the lifetime of the variation or all flags call. This priming call is being removed in favor of a simple TTL cache. The cache will be populated on the initial usage of the SDK, and then periodically as it is detected to be expired. The TTL can be configured with: - Positive value representing the time to cache the value - 0 to cache the value indefinitely. This allows a customer to initialize the SDK within an EdgeWorker handler, and get a "snapshot" of the view for the lifetime of the SDK. - Negative value representing no cache. This value is highly discouraged as usage restrictions in Akamai make it ineffective.
6eb196a
to
cfe2a73
Compare
kinyoklion
reviewed
Feb 21, 2025
kinyoklion
reviewed
Feb 21, 2025
packages/shared/akamai-edgeworker-sdk/src/featureStore/index.ts
Outdated
Show resolved
Hide resolved
tanderson-ld
approved these changes
Feb 21, 2025
kinyoklion
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the LDClient would issue a call to prime the store with
data, which would be retained for the lifetime of the variation or all
flags call.
This priming call is being removed in favor of a simple TTL cache. The
cache will be populated on the initial usage of the SDK, and then
periodically as it is detected to be expired.
The TTL can be configured with:
initialize the SDK within an EdgeWorker handler, and get a "snapshot"
of the view for the lifetime of the SDK.
as usage restrictions in Akamai make it ineffective.