Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge goreleaser action into release please workflow #245

Merged
merged 10 commits into from
Dec 10, 2024

Conversation

sloloris
Copy link
Member

@sloloris sloloris commented Dec 9, 2024

This merges the old tag-for-release.yml (release please) and release.yml (goreleaser) into one single release.yml. Theoretically this should trigger all the steps after the first one (id: release) only when release please has actually created a release (i.e. after merging of PR). This should bypass the need for an extra PAT to avoid Github's whole ignoring-of-RP-resources-to-prevent-recursive-action-triggers thing.

@sloloris sloloris changed the title try doing it all in one flow chore: merge goreleaser action into release please workflow Dec 9, 2024
@sloloris sloloris requested review from keelerm84 and ldhenry December 9, 2024 15:40
@sloloris sloloris marked this pull request as ready for review December 10, 2024 12:54
@sloloris sloloris requested a review from a team as a code owner December 10, 2024 12:54
@sloloris sloloris merged commit 834a3ac into main Dec 10, 2024
27 checks passed
@sloloris sloloris deleted the imiller/REL-4176/create-one-single-action branch December 10, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants