Early returning in -[LSHTTPStubURLProtocol startLoading] to prevent failures#154
Open
cristik wants to merge 1 commit intolausobo:masterfrom
Open
Early returning in -[LSHTTPStubURLProtocol startLoading] to prevent failures#154cristik wants to merge 1 commit intolausobo:masterfrom
cristik wants to merge 1 commit intolausobo:masterfrom
Conversation
…ailures Since `NSURLSession` will execute the requests on a background thread, we can end up in the situation when the `tearDown` of a previous unit test stops Nocilla since it no longer needs it, and `startLoading` gets called while in the middle of another unrelated test case, thus causing an exception and failing the other test. So, we're early returning from `startLoading` to prevent this kind of failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
NSURLSessionwill execute the requests on a background thread, we can end up in the situation when thetearDownof a previous unit test stops Nocilla since it no longer needs it, andstartLoadinggets called while in the middle of another unrelated test case, thus causing an exception and failing the other test.So, we're early returning from
startLoadingto prevent this kind of failures.