Open
Conversation
Contributor
Author
|
Would be great if someone more familiar with Kiwi, Mocking or Nocilla could chime in on the |
Nocilla/Stubs/LSStubRequest.m
Outdated
Contributor
Author
There was a problem hiding this comment.
The json != nil is unnecessary
Contributor
Author
|
Build failed because xctool is already installed 😒 |
Owner
|
@robb I just outlined here the ideal way of implementing support for arbitraty matching logic. This approach has been possible from day one, it didn't occur to me to use it for json, apologies. I like better the approach outlined there because it keep the surface of the DSL to a minimum, and does not couple the DSL to specific content types, which has been always my concern about implementing JSON support this particular way. Let me know what you think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As alluded to on Twitter, this allows users to use JSON in request and response bodies. E.g.:
It works by parsing the JSON contents if the header are set appropriately and comparing the dictionaries, which makes us independent of internals of
NSJSONSerialization.I had some trouble getting
masterto build on my machine and in Xcode 6. I updated some of the dependencies to please the compiler but had to mark two tests as pending for the time being.