Skip to content
This repository was archived by the owner on Sep 13, 2023. It is now read-only.

Feature/editor full screen mode #103

Closed

Conversation

probil
Copy link

@probil probil commented Oct 13, 2019

Fixes #69

  • Adds fullscreen mode during edition and creation of code snippet
  • Increases font size in editor a bit

Screenshot from 2019-10-13 15-14-45
Screenshot from 2019-10-13 15-15-02

@lauthieb
Copy link
Owner

Hi @probil, thanks a lot for this PR.
I’m on vacation sorry but I will review and test your work ASAP.
Thank you

@probil
Copy link
Author

probil commented Oct 16, 2019

Hi @lauthieb Thanks for response
Take your time :) I'll try to fix other things in the meanwhile

@lauthieb
Copy link
Owner

lauthieb commented Oct 17, 2019

Nice @probil! Thanks a lot for your work on Code Notes.
But on MacOS, I've got this (the editor appears on topbar) :

Capture d’écran 2019-10-18 à 00 24 45

@probil
Copy link
Author

probil commented Oct 18, 2019

@lauthieb I'm not an expert in electron but I think there should be some kind of configuration to enable on Mac (similar to windows & linux)

Any ideas?

@lauthieb
Copy link
Owner

@probil nope sorry, maybe you should get some advices from the community of our contributors.
Thanks a lot again for this work and sorry for the delay, I haven't so much time for Code Notes now... :(

@lauthieb
Copy link
Owner

lauthieb commented Dec 4, 2019

@probil Can you please fix conflicts and update your branch with just your modifications?
Sorry for the inconvenience it was mandatory to force push master after several tries to fix this important bug #110

Here you can download the new version 1.2.3 : https://github.com/lauthieb/code-notes/releases/tag/1.2.3

Thanks a lot in advance for this.

@lauthieb
Copy link
Owner

lauthieb commented Jan 8, 2020

Hi @probil, happy new year 🎉
What about the conflict resolution and this issue?
Do you want to continue this Pull Request?
Thanks a in advance. Have a great day :)

@probil
Copy link
Author

probil commented Jan 8, 2020

@lauthieb Happy New Year!
yeah, I will rebase it on latest master and resolve conflicts

@probil probil force-pushed the feature/editor-full-screen-mode branch from 0e110d9 to 962ecab Compare January 8, 2020 12:27
@probil
Copy link
Author

probil commented Jan 8, 2020

@lauthieb done

@lauthieb lauthieb closed this Jul 22, 2020
@lauthieb lauthieb reopened this Jan 1, 2021
@stale
Copy link

stale bot commented Mar 2, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 2, 2021
@stale stale bot closed this Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Very small edit window for text
2 participants