Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one finger scroll && double tap && winmax fix #20

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

kingo132
Copy link

@kingo132 kingo132 commented Jan 7, 2021

  1. Fixed multitouch problem for winmax. (By hard code the resolution of winmax in the driver, this is what makes it for winmax only)
  2. Fixed initialization problem for winmax, which will fail to load driver occasionally at boot
  3. One finger default to scroll, one finger long press act as the original drag
  4. Fixed double tap problem, the original one does not have double tap

@lazd
Copy link
Owner

lazd commented Mar 22, 2023

Whoa, apologies for not getting to this sooner! I will test these changes soon and will merge/release if it works. I was actually trying to play around with double clicking and arrived upon a similar solution, but couldn't get it working consistently. I'm excited to test this out!

@lazd
Copy link
Owner

lazd commented Mar 22, 2023

I was unable to build this locally, but I was able to apply the same very simple technique of just triggering click twice inside of checkForClick to get double clicking working! Coupled with the fuzzy location code I added for imprecise fat finger support, it really works nicely.

I do want to investigate the cursor hiding routines, but I think that's the reason it wouldn't build (missing some library?).

Finally, i think one finger scroll is interesting, but selecting text and dragging files around are too common of interactions on a desktop style machine, and I feel it would end up frustrating. Unless there's a way to toggle this behavior, I don't know if I would want to include it in the driver.

Thanks again for your contribution, and my apologies for not getting back to you sooner!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants