WIP: missing tokenBag methods #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 15, 2020 17:43
|
NOTE: the Verifier contract tests are failing due to the bytecode becoming too large. I intend to patch-fix this in this PR and work on this problem more generally in a separate issue. |
johannbarbie
approved these changes
Jan 29, 2020
| return (token, success); | ||
| } | ||
|
|
||
| function findToken2( |
There was a problem hiding this comment.
document the difference to findToken, including selector param :)
contracts/EVMTokenBag.slb
Outdated
| } | ||
|
|
There was a problem hiding this comment.
The devil's work.
Co-Authored-By: Johann Barbie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #175
Also fixes:
#177