Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: minimize amount of blocks in function call #95

Merged
merged 4 commits into from
Apr 22, 2024
Merged

chore: minimize amount of blocks in function call #95

merged 4 commits into from
Apr 22, 2024

Conversation

koen1711
Copy link
Member

No description provided.

@koen1711 koen1711 requested a review from a team as a code owner April 22, 2024 14:31
@koen1711 koen1711 requested a review from rmoesbergen April 22, 2024 14:31
@rmoesbergen
Copy link
Member

Hmm, this doesn't make much sense to me. The block definition and generator are now in different locations (arduino.ts vs. leaphy_common.ts for example). Any why exactly is blocks being int the getBlocks() function a bad thing? Now if you need the board parameters for a block that didn't have them before, the blocks suddenly needs to move to a different file? Weird.

@sverben
Copy link
Member

sverben commented Apr 22, 2024

Hmm, this doesn't make much sense to me. The block definition and generator are now in different locations (arduino.ts vs. leaphy_common.ts for example). Any why exactly is blocks being int the getBlocks() function a bad thing? Now if you need the board parameters for a block that didn't have them before, the blocks suddenly needs to move to a different file? Weird.

eens

@koen1711
Copy link
Member Author

Hmm, this doesn't make much sense to me. The block definition and generator are now in different locations (arduino.ts vs. leaphy_common.ts for example). Any why exactly is blocks being int the getBlocks() function a bad thing? Now if you need the board parameters for a block that didn't have them before, the blocks suddenly needs to move to a different file? Weird.

We fix the long time not fixed issue of redefining every block.

@koen1711 koen1711 merged commit 49e6b5e into main Apr 22, 2024
1 check passed
@koen1711 koen1711 deleted the cleanup branch April 22, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants