Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Sentry-based user feedback form #55

Merged
merged 11 commits into from
May 11, 2024
Merged

feat: add Sentry-based user feedback form #55

merged 11 commits into from
May 11, 2024

Conversation

rmoesbergen
Copy link
Member

No description provided.

@rmoesbergen rmoesbergen requested a review from a team as a code owner May 9, 2024 14:14
@rmoesbergen rmoesbergen requested a review from sverben May 9, 2024 14:14
@rmoesbergen
Copy link
Member Author

WIP

ready

@rmoesbergen rmoesbergen linked an issue May 9, 2024 that may be closed by this pull request
[enhancement] Create a "report an issue" dialog #19
Closed
sverben
sverben requested changes May 9, 2024
View reviewed changes
Copy link
Member

@sverben sverben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none of the fields are now actually required, so the user can submit empty feedback, also the email field doesn't check the email's validity, please set the email's input type to email

@rmoesbergen rmoesbergen requested a review from sverben May 11, 2024 14:40
@rmoesbergen
Copy link
Member Author

none of the fields are now actually required, so the user can submit empty feedback, also the email field doesn't check the email's validity, please set the email's input type to email

fixed

sverben
sverben requested changes May 11, 2024
View reviewed changes
@rmoesbergen rmoesbergen requested a review from sverben May 11, 2024 17:50
@rmoesbergen rmoesbergen merged commit dee86d4 into main May 11, 2024
1 check passed
@rmoesbergen rmoesbergen deleted the user-feedback branch May 11, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverben sverben sverben approved these changes

@koen1711 koen1711 koen1711 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[enhancement] Create a "report an issue" dialog
3 participants
@rmoesbergen @sverben @koen1711