Skip to content

Handle case where the file extension has changed from the original filename#584

Merged
marcellamaki merged 1 commit intolearningequality:developfrom
rtibbles:a_file_by_any_other_name_may_have_a_different_extension
Apr 8, 2025
Merged

Handle case where the file extension has changed from the original filename#584
marcellamaki merged 1 commit intolearningequality:developfrom
rtibbles:a_file_by_any_other_name_may_have_a_different_extension

Conversation

@rtibbles
Copy link
Copy Markdown
Member

@rtibbles rtibbles commented Mar 7, 2025

Summary

  • Studio ignores the file format we send and just uses the "filename" property to determine the appropriate extension for the file
  • We already handled the case when the extension did not exist, this adds handling for when the file has been converted, so the original filename extension and the extension of the file we are uploading are totally different

See Slack discussion for more details: https://learningequality.slack.com/archives/C6S90FCDT/p1740676947066549

@rtibbles rtibbles force-pushed the a_file_by_any_other_name_may_have_a_different_extension branch from 164d34b to 2b4dfb2 Compare March 8, 2025 00:41
@marcellamaki marcellamaki self-assigned this Mar 25, 2025
Copy link
Copy Markdown
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code update makes sense to me, just not sure if doing something to test this would be helpful, or if we can approve from here

Copy link
Copy Markdown
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

co-reviewed relevant studio code. Since the file format was being ignored, we added in the extra check.

@marcellamaki marcellamaki merged commit 1f419e8 into learningequality:develop Apr 8, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants