Courses, Units, Lessons, and KPUB#653
Courses, Units, Lessons, and KPUB#653rtibbles wants to merge 4 commits intolearningequality:mainfrom
Conversation
bjester
left a comment
bjester
left a comment
There was a problem hiding this comment.
Needs to update the le_utils version
|
Updated! |
|
Have reworked and deduplicated the tests here. |
bjester
left a comment
bjester
left a comment
There was a problem hiding this comment.
Overall everything looks good enough for merge, but I think it'd be worthwhile to match exception messages in TestUnitNodeValidation considering the complexity of the validation. And so for that, at least, I'm requesting changes.
| Args: | ||
| node: LessonNode to add | ||
| learning_objectives: List of LearningObjective instances |
There was a problem hiding this comment.
Seems ricecooker has inconsistent docstring styles...
There was a problem hiding this comment.
Yes, they're all over the shop - I think we should just decide what our standard is across our repos and then standardize.
html5lib sets body.text to None when the body element starts with a child element rather than text. Guard against this the same way as KPUBConversionHandler. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Updated! |
bjester
left a comment
bjester
left a comment
There was a problem hiding this comment.
Looks good to me. All previous code review items resolved.
2 participants
Summary
Adds support for uploading KPUB files
Adds Courses, Units, and Lessons nodes with validation
Adds example courses script for two sample courses.
References
Fixes #638
Reviewer guidance