Ruby 3.2 upgrade #255
Draft
Ruby 3.2 upgrade #255
+53,006
−23,140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires attention. See https://github.com/railsware/js-routes/blob/master/VERSION_2_UPGRADE.md for details. Upgrade needed for compatibility for Ruby 3.2
paranoicsan
added
dependencies
Removed `Lcms::Engine::DocumentPresenter#short_url` method.
Also upgrade acts-as-taggable-on to v9.0 for Rails 7 support.
And move it to `development dependencies`
1. Updated universal Dockerfile 2. Remove legacy images and styles 3. Introduce new way ReactJS components are rendered - Admin::ReactComponentsHelper#render_component 4. Cleanup unused locale keys, controllers, services and view
Trying to make it work.
- start container ONLY - start container AND install gems ONLY - start container, install gems AND launch yarn
This solves wrong paths errors
Updated the material filtering logic to support multiple grade values. Added a value transformation method for orientation in the search form. Removed 'grade' from strict metadata and replaced it with 'grades' to accommodate multi-value inputs.
This commit introduces a new seed file to populate the development database with predefined standards. The script adds three sample standards to the Lcms::Engine::Standard model, facilitating easier development and testing.
Minor updates
Possibly can break the inherited controllers. Apply changes carefully. Unified query handling by extracting common query logic into `Lcms::Engine::Queryable` concern. Updated controllers and views to use the new concern for setting query parameters and constructing query structs, improving code maintainability and reducing redundancy. This allows us to get rid of OpenStruct usage completely.
[BREAKING] Refactor query handling in admin controllers
Update `Queryable` module to namespace query attribute keys and add a new guide document for overriding controllers in Rails 7. This enhances code structure and provides a clear example for extending controller functionality in a Rails 7 application.
Added query parameters to redirection paths in both documents and materials controllers, ensuring consistent parameter passing. Also updated the corresponding views to maintain query parameters in navigation links, improving user navigation and state retention.
Upgraded CKEditor from version 4.20.0 to 4.22.1 and changed gem dependency to ensure minimum version 5.1.3. 4.22 is the last Open Source version available. For now, we should hide the fake warning about security. It seems the warning is shown to move users to v5 and buy the license.
Update CKEditor version
Add resource destruction callback to Document model. Ensure that associated resources are destroyed when a Document is deleted. Added tests to verify this behavior in the Document model's spec.
- updates some gems - fix the RBS to comply with new RBS collections - refactor Resource model to make it more readable - FIX thumbnail class (bugs found with RBS type check)
Destroy lessons's resources
Refactor the `where_metadata_in` method to handle additional table names. This change introduces a case statement to correctly associate the model name with its corresponding database table, raising an error for unknown names. This enhances the method's robustness and extends its support to include the `Dese::Lcms::Engine::Document` model.
paranoicsan
force-pushed
the
ruby-3-upgrade
branch
from
6874263 to
d8ad149
Compare
Implemented: - WebhookConfiguration and WebhookCallJob - Api::BaseController with HMAC authentication (using SHA256). - api/resources Additionally: Updated gem version Specified foundation-rails version to avoid issues with scss rbs_rails added to help with rbs definitions; rbs definitions for new files added
Add Webhook feature and api to get resources
[hotfix] fixed strip content to respect tag's placeholder
shlag3n
force-pushed
the
ruby-3-upgrade
branch
from
6c29400 to
0537fd6
Compare
shlag3n
force-pushed
the
ruby-3-upgrade
branch
from
0537fd6 to
c087cea
Compare
fixed parsing tables with thead
shlag3n
force-pushed
the
ruby-3-upgrade
branch
from
2f11d45 to
fbec3b4
Compare
shlag3n
force-pushed
the
ruby-3-upgrade
branch
from
fbec3b4 to
dae31c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: