Skip to content
This repository has been archived by the owner on Dec 6, 2019. It is now read-only.

(WIP) Swaps out svg file #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomasoboyle
Copy link

Swaps out svg file.

Problems with resizing image. Help please?

TODO: re-name all "icon-github" to "icon-meetup".

@mhelmetag
Copy link
Contributor

Relates to #2

I didn't really mean to swap out the files. I meant to add a new icon to our meetup page with the meetup link. Just in a similar style to the github icon.

Other than that. This is pretty similar to what I'd want.

I would make a new icon called like icon-meetup.svg in the same folder and then add a another <span> pair with the meetup link to this file https://github.com/learntocodesb/learn-to-code-blog/blob/master/_includes/footer.html. I've commented out where I think it would go.

The html file that you edited is actually what's included in each post.

I can totally help out with sizing (not sure how to do that myself actually).

This is a great start though!! Props for getting set up!

@mhelmetag
Copy link
Contributor

Oh and let me know when you'll have some time. I'd be more than happy to jump on screen hero or something and help get this merged!

@thomasoboyle
Copy link
Author

Thanks so much Max! I think today is already a bit shot but I'd love to get at this again real soon. I really appreciate all the great feedback. I want to give it another try before I come at you for help. Thanks for being so available!

@mhelmetag
Copy link
Contributor

Awesome! I look forward to your next commit!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants