Merge pull request #79 from learnweb/feature/automatic-eval-request-disable-new-dates-for-evalrequest

Feature/automatic eval request disable new dates for evalrequest

Author: Laur0r

amd/build/initialize.min.js

@@ -20,6 +20,7 @@ define(['jquery', 'core/notification', 'core/str'], function ($, notification, s
         $('[name=year_end]').last()[0].selectedIndex = end.getFullYear() - 2000;
         if ($('#reactivate').length > 0) {
             endenabled = !$('[name=minute_end]')[0].disabled;
+            datedisabled = $('[name=minute_end]')[0].disabled && $('[name=minute_start]')[0].disabled;
             $(document).on("change", "#reactivate", function() {
                 if (this.checked) {
                     // Ask for confirmation, then enable all fields related to re-invitation.
@@ -51,6 +52,9 @@ define(['jquery', 'core/notification', 'core/str'], function ($, notification, s
                                 if ($('#only_end').length > 0) {
                                     $('#only_end').prop("value", false);
                                 }
+                                if ($('#datedisabled').length > 0) {
+                                    $('#datedisabled').prop("value", false);
+                                }
                                 if ($('#evasyssubmitbutton').length > 0) {
                                     $('#evasyssubmitbutton').prop("disabled", false);
                                     $('#evasyssubmitbutton').val(s[4]);
@@ -81,6 +85,9 @@ define(['jquery', 'core/notification', 'core/str'], function ($, notification, s
                     if ($('#only_end').length > 0) {
                         $('#only_end').prop("value", true);
                     }
+                    if ($('#datedisabled').length > 0) {
+                        $('#datedisabled').prop("value", true);
+                    }
                     if ($('#evasyssubmitbutton').length > 0) {
                         if (!endenabled) {
                             $('#evasyssubmitbutton').prop("disabled", true);

amd/build/post_dialog.min.js

@@ -22,6 +22,17 @@ define(['jquery', 'core/notification', 'core/str'], function($, notification, st
         ).fail(notification.exception);
     };
 
+    var show_dialog_success_and_info = function() {
+        str.get_strings([
+            {'key' : 'title_success', component: 'block_evasys_sync'},
+            {'key' : 'content_successandinfo', component: 'block_evasys_sync'},
+            {'key' : 'confirm_box', component: 'block_evasys_sync'},
+        ]).done(function(s) {
+                notification.alert(s[0], s[1], s[2]);
+            }
+        ).fail(notification.exception);
+    }
+
     var show_dialog_nostudents = function() {
         str.get_strings([
             {'key' : 'title_failure', component: 'block_evasys_sync'},
@@ -48,6 +59,7 @@ define(['jquery', 'core/notification', 'core/str'], function($, notification, st
         show_dialog_failure: show_dialog_failure,
         show_dialog_no_students: show_dialog_nostudents,
         show_dialog_success: show_dialog_success,
-        show_dialog_up_to_date: show_dialog_up_to_date
+        show_dialog_up_to_date: show_dialog_up_to_date,
+        show_dialog_success_and_info: show_dialog_success_and_info
     };
 });

amd/build/standardtime.min.js

@@ -34,6 +34,7 @@ define(['jquery', 'core/str'], function($, str) {
         $('[name=month_end]')[0].disabled = true;
         $('[name=year_end]')[0].disabled = true;
         $('#only_end').val(false);
+        $('#datedisabled').val(true);
     };
 
     var enable = function() {

amd/src/initialize.js

@@ -98,6 +98,7 @@ public function get_content() {
         $enddisabled = false;
         $emailsentnotice = false;
         $periodsetnotice = false;
+        $datedisabled = false;
 
         // Set start to today and end to a week from now.
         $start = time();
@@ -115,6 +116,7 @@ public function get_content() {
             $first = array_key_first($evaluations->evaluations);
             $start = $evaluations->evaluations[$first]->start;
             $end = $evaluations->evaluations[$first]->end;
+            $datedisabled = true;
         } elseif ($evasyscategory->default_period_set()) {
             $start = $evasyscategory->get('standard_time_start');
             $end = $evasyscategory->get('standard_time_end');
@@ -186,8 +188,9 @@ public function get_content() {
                 'usestandardtimelayout' => $standardttimemode,
             // Choose mode.
                 'direct' => false,
-                'startdisabled' => $startdisabled || $standardttimemode,
-                'enddisabled' => $enddisabled || $standardttimemode,
+                'startdisabled' => $startdisabled || $standardttimemode || $datedisabled,
+                'enddisabled' => $enddisabled || $standardttimemode || $datedisabled,
+                'datedisabled' => $datedisabled,
                 'onlyend' => $startdisabled && !$standardttimemode,
                 'disablesubmit' => $enddisabled,
             // If the evaluation hasn't ended yet, display option to restart it.
@@ -223,6 +226,8 @@ public function display_status($status) {
             $this->page->requires->js_call_amd('block_evasys_sync/post_dialog', 'show_dialog_success');
         } else if ($status === 'uptodate') {
             $this->page->requires->js_call_amd('block_evasys_sync/post_dialog', 'show_dialog_up_to_date');
+        } else if ($status === 'successandinfo') {
+            $this->page->requires->js_call_amd('block_evasys_sync/post_dialog', 'show_dialog_success_and_info');
         } else if ($status === 'nostudents') {
             $this->page->requires->js_call_amd('block_evasys_sync/post_dialog', 'show_dialog_no_students');
         } else if ($status === 'failure') {

amd/src/post_dialog.js

@@ -365,7 +365,7 @@ static public function get_assigned_user($course) {
      * Set time period for evaluation.
      *
      * @param array $dates expects keys `start' and `end' with timestamp values.
-     * @return bool true if the dates have changed or if the record is new.
+     * @return bool true if the date record is new.
      * @throws \coding_exception
      * @throws \dml_missing_record_exception
      */
@@ -375,10 +375,11 @@ public function set_evaluation_period($dates) : bool {
         if ($usestandardtime) {
             $dates = self::get_standard_timemode($course->category);
         }
-        $changed = false;
+        $new = false;
         $data = evaluation::for_course($this->courseid);
         if (!$data) {
             $data = new evaluation();
+            $new = true;
             $data->courses = [$this->courseid];
             foreach ($this->courseinformation as $lsfid => $information) {
                 $data->evaluations[$lsfid] = (object) [
@@ -392,15 +393,14 @@ public function set_evaluation_period($dates) : bool {
         } else {
             foreach ($data->evaluations as &$evaluation) {
                 if ($evaluation->start != $dates['start'] || $evaluation->end != $dates['end']) {
-                    $changed = true;
                     $evaluation->start = $dates['start'];
                     $evaluation->end = $dates['end'];
                 }
             }
         }
         $data->save();
 
-        return $changed;
+        return $new;
     }
 
     /**