Prototype for starting evaluations as evasys coordinator #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lags to evasys category
Laur0r
reviewed
Apr 6, 2023
justusdieckmann
force-pushed
the
feature/automatic-eval-request
branch
from
b941b73 to
f738b1f
Compare
Laur0r
reviewed
Apr 12, 2023
justusdieckmann
force-pushed
the
feature/automatic-eval-request
branch
2 times, most recently
from
d748ba0 to
7c03595
Compare
justusdieckmann
force-pushed
the
feature/automatic-eval-request
branch
from
7c03595 to
4978bc5
Compare
justusdieckmann
force-pushed
the
feature/automatic-eval-request
branch
from
4f4e011 to
60021f4
Compare
Laur0r
reviewed
May 19, 2023
block_evasys_sync.php
Outdated
| $evasyscategory = \block_evasys_sync\evasys_category::for_course($this->page->course); | ||
|
|
||
| if (!$evasyscategory) { | ||
| $this->content->text = 'This course isn\'t inside any evaluation category!'; |
There was a problem hiding this comment.
This should not be hardcoded but added to lang and also translated to German.
Laur0r
reviewed
May 19, 2023
| ); | ||
|
|
||
| $this->content->text .= $OUTPUT->render_from_template("block_evasys_sync/block", $data); | ||
|
|
||
| if (!$evasyscategory->can_teacher_request_evaluation()) { | ||
| $this->content->text .= get_string('teacher_request_disabled', 'block_evasys_sync'); |
There was a problem hiding this comment.
This string has no translation to German.
justusdieckmann
force-pushed
the
feature/automatic-eval-request
branch
from
2455ffd to
52af406
Compare
…atch-cron Move bulk synchronization to cron task
…mprove-adminsettings changed course category select to autocomplete element in admin settings
…r requested evaluations to teachers optional
…mail-optional-no-update feature/automatic-eval-request email optional without db upgrade
|
Great thanks! Is has been in production for quite some time now without any errors :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.