codecleaning

Author: TamaroWalter

Diff for: classes/output/helpicon.php

@@ -46,7 +46,7 @@ public function __construct($htmlclass, $content) {
         $iconstyle = ['style' =>
                       'max-width: 20px; max-height: 20px; margin: 0; padding: 0; box-sizing: content-box; margin-right: .5rem;'];
         $icon = \html_writer::img($iconurl, $content, $iconstyle);
-        //                           'style' => 'display: inline-block; max-width: 100%; max-height: 100%;',
+
         $class = $htmlclass;
         $iconattributes = ['role' => 'button',
                            'style' => 'display: inline;',

Diff for: classes/tables/userstats_table.php

@@ -152,33 +152,11 @@ public function get_usertable() {
      * Setup the help icon for amount of activity
      */
     public function set_helpactivity() {
-        global $CFG;
         $htmlclass = 'helpactivityclass btn btn-link';
         $content = get_string('helpamountofactivity', 'moodleoverflow');
         $helpobject = new helpicon($htmlclass, $content);
         $this->helpactivity = new \stdClass();
         $this->helpactivity->object = $helpobject->get_helpicon();
-        /*
-        $this->helpactivity = new \stdClass();
-        $this->helpactivity->iconurl = $CFG->wwwroot . '/pix/a/help.svg';
-        $this->helpactivity->icon = \html_writer::img($this->helpactivity->iconurl,
-                                                      get_string('helpamountofactivity', 'moodleoverflow'));
-        $this->helpactivity->class = 'helpactivityclass btn btn-link';
-        $this->helpactivity->iconattributes = ['role' => 'button',
-                                               'data-container' => 'body',
-                                               'data-toggle' => 'popover',
-                                               'data-placement' => 'right',
-                                               'data-action' => 'showhelpicon',
-                                               'data-html' => 'true',
-                                               'data-trigger' => 'focus',
-                                               'tabindex' => '0',
-                                               'data-content' => '<div class=&quot;no-overflow&quot;><p>' .
-                                                    get_string('helpamountofactivity', 'moodleoverflow') .
-                                                    '</p> </div>', ];
-
-        $this->helpactivity->object = \html_writer::span($this->helpactivity->icon,
-                                                         $this->helpactivity->class,
-                                                         $this->helpactivity->iconattributes);*/
     }
 
     // Functions that show the data.

Diff for: locallib.php

@@ -1527,7 +1527,7 @@ function moodleoverflow_print_post($post, $discussion, $moodleoverflow, $cm, $co
  * @param stdClass $limitedanswersetting Two Unix timestamp wrapped in a stdClass, upper and lower label for answering.
  * @return bool
  */
-function is_currently_time_limited($limitedanswersetting) : bool {
+function is_currently_time_limited($limitedanswersetting): bool {
     return ($limitedanswersetting->la_starttime != 0 && $limitedanswersetting->la_starttime > time())
     || ($limitedanswersetting->la_endtime != 0 && $limitedanswersetting->la_endtime < time());
 }