Skip to content

HTML entities are double-escaped in discussion titles #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
christianp opened this issue Jun 27, 2020 · 0 comments · Fixed by #58
Closed

HTML entities are double-escaped in discussion titles #56

christianp opened this issue Jun 27, 2020 · 0 comments · Fixed by #58

Comments

@christianp
Copy link
Contributor

If I give a discussion topic a name like Q&A, it's rendered as Q&A - it looks like the string has HTML entities escaped twice.
christianp added a commit to christianp/moodle-mod_moodleoverflow that referenced this issue Jun 27, 2020
@christianp
pass 'escape' => false to format_string
7027837 
fixes learnweb#56
@christianp christianp mentioned this issue Jun 27, 2020
Closed
christianp added a commit to christianp/moodle-mod_moodleoverflow that referenced this issue Jun 29, 2020
@christianp
don't double escape discussion subjects
90f90f4 
This uses triple curly braces around discussion subjects in the mustache
templates to avoid double-escaping HTML entities, since format_string also escapes.

fixes learnweb#56
@christianp christianp mentioned this issue Jun 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@christianp