Skip to content

pass 'escape' => false to format_string #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

christianp
Copy link
Contributor

fixes #56

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2020

Codecov Report

Merging #57 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #57   +/-   ##
=========================================
  Coverage     18.08%   18.08%           
  Complexity      453      453           
=========================================
  Files            43       43           
  Lines          3982     3982           
=========================================
  Hits            720      720           
  Misses         3262     3262           
Impacted Files Coverage Δ Complexity Δ
locallib.php 6.52% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaf990b...7027837. Read the comment docs.

Copy link
Contributor

@Dagefoerde Dagefoerde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for suggesting a fix. Do you know where and how the strings that your fix modifies are actually rendered into output?

Are they all passed to Mustache templates? If that is the case I would prefer changing the respective Mustache templates instead. Three curly braces, i. e. {{{a}}} instead of {{a}}, cause a to be rendered without additional escaping.

@christianp
Copy link
Contributor Author

Ah, I didn't know about that. I've removed this commit from my branch and pushed a new one, but that doesn't seem to have updated this PR. I'll close this and make a new one.

@christianp christianp closed this Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML entities are double-escaped in discussion titles
3 participants