Moodle PHP documentation #321
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaboesch
force-pushed
the
moodlephpdoc
branch
3 times, most recently
from
52720cc to
f1c8a3c
Compare
Member
|
Thanks, I have removed the fix for the Behat tests for now. Partly |
Contributor
Author
|
Cool, all good. |
Contributor
Author
|
Whilst you're at it, #314 seems legit, too. |
Member
|
Yes, weirdly enough the tests pass for Moodle 4.5 and lower anyways...
|
Member
|
Whilst you're at it, #314 seems legit, too.
True, I have already been testing this patch a while ago and it solves the issue partially. However, I remember that something still did not work. Will have a look again...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix all checks for Moodle coding style.