feat: bitcoin contracts query #4679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Polybius93
commented
Dec 12, 2023
•
Polybius93
commented
Polybius93
force-pushed
the
feat/contracts-query
branch
from
22273ce to
b8478c4
Compare
kyranjamie
reviewed
Dec 13, 2023
|
|
||
| export function useBitcoinContractsBalanceQuery(): UseQueryResult<Money> { | ||
| const { sumBitcoinContractCollateralAmounts } = useBitcoinContracts(); | ||
| const { address } = useCurrentAccountNativeSegwitIndexZeroSigner(); |
There was a problem hiding this comment.
This might break if we are using ledger and there is no bitcoin keys. Account index would work the same I think?
or do we only ever cal this when we know the are bitcoin keys?
Polybius93
force-pushed
the
feat/contracts-query
branch
from
b8478c4 to
332c4cd
Compare
Polybius93
force-pushed
the
feat/contracts-query
branch
from
332c4cd to
b90619f
Compare
kyranjamie
approved these changes
Dec 13, 2023
| @@ -26,6 +26,8 @@ export function BitcoinContractEntryPointLayout(props: BitcoinContractEntryPoint | |||
| : balance.amount.toString(); | |||
| const formattedBalance = formatBalance(amount); | |||
|
|
|||
| if (Number(balance.amount) === 0) return false; | |||
Comment on lines
16
to
23
| const [bitcoinContractsBalanceInUSD, setBitcoinContractsBalanceInUSD] = useState<string>('0'); | ||
|
|
||
| useEffect(() => { | ||
| if (isUndefined(bitcoinContractsBalance)) return; | ||
| setBitcoinContractsBalanceInUSD( | ||
| i18nFormatCurrency(calculateFiatValue(createMoney(bitcoinContractsBalance.amount, 'BTC'))) | ||
| ); | ||
| }, [bitcoinContractsBalance, calculateFiatValue]); |
There was a problem hiding this comment.
Perhaps better written as a fn that an effect that sets state?
There was a problem hiding this comment.
Removed this unnecessary useEffect.
Polybius93
force-pushed
the
feat/contracts-query
branch
from
cab7687 to
018622c
Compare
…f balance is undefined
Polybius93
force-pushed
the
feat/contracts-query
branch
from
018622c to
90988c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.