Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use light mode background on icons on fund screen #4697

Merged
merged 1 commit into from
Dec 14, 2023
Merged

fix: use light mode background on icons on fund screen #4697

merged 1 commit into from
Dec 14, 2023

Conversation

edgarkhanzadian
Copy link
Contributor

@edgarkhanzadian edgarkhanzadian commented Dec 14, 2023 •
edited by github-actions bot
Loading

Try out this version of Leather — Extension build, Test report

Fixes #4691

lightModeBackgroundIcons

@pete-watters
Copy link
Contributor

I tested this and it's working. I noticed the modal BG location is not working anymore though:
Screenshot 2023-12-14 at 09 51 45

@edgarkhanzadian
Copy link
Contributor Author

@pete-watters oh shoot, probably messed it up with my other PR! Will take a look, thank you for catching this!

@edgarkhanzadian edgarkhanzadian added this pull request to the merge queue Dec 14, 2023
Merged via the queue into dev with commit 8d160b0 Dec 14, 2023
26 checks passed
@edgarkhanzadian edgarkhanzadian deleted the fix/light-mode-icons branch December 14, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranjamie kyranjamie kyranjamie approved these changes

@pete-watters pete-watters pete-watters approved these changes

@fbwoolf fbwoolf Awaiting requested review from fbwoolf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display icons on buy screen properly for dark mode
3 participants
@edgarkhanzadian @pete-watters @kyranjamie