Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NaN total amount bug #4756

Merged
merged 1 commit into from
Jan 8, 2024
Merged

fix: NaN total amount bug #4756

merged 1 commit into from
Jan 8, 2024

Conversation

alter-eggo
Copy link
Contributor

@alter-eggo alter-eggo commented Dec 25, 2023 •
edited by github-actions bot
Loading

Try out this version of Leather — Extension build, Test report

fix bug with NaN total amount
Screenshot 2023-12-25 at 13 42 46

@alter-eggo alter-eggo changed the title fix: nan total amount bug fix: NaN total amount bug Dec 25, 2023
@alter-eggo alter-eggo marked this pull request as ready for review December 26, 2023 06:14
@markmhendrickson
Copy link
Collaborator

Please link PR to issue under "Development" 🙏

image

@alter-eggo alter-eggo linked an issue Jan 3, 2024 that may be closed by this pull request
Bug with NaN total amount #4768
Closed
@alter-eggo alter-eggo added this pull request to the merge queue Jan 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2024
@alter-eggo alter-eggo added this pull request to the merge queue Jan 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2024
@alter-eggo alter-eggo added this pull request to the merge queue Jan 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2024
@alter-eggo alter-eggo force-pushed the fix/nan-total-amount branch from c3919fa to fc23e9f Compare January 8, 2024 17:22
@alter-eggo alter-eggo added this pull request to the merge queue Jan 8, 2024
Merged via the queue into dev with commit 8c37393 Jan 8, 2024
26 checks passed
@alter-eggo alter-eggo deleted the fix/nan-total-amount branch January 8, 2024 17:33
@alter-eggo alter-eggo restored the fix/nan-total-amount branch January 9, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyranjamie kyranjamie kyranjamie approved these changes

@fbwoolf fbwoolf fbwoolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug with NaN total amount
4 participants
@alter-eggo @markmhendrickson @kyranjamie @fbwoolf