refactor: icons to use variants default and small, closes #4950 #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranjamie
approved these changes
Feb 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
src/app/components/stacks-transaction-item/increase-fee-button.tsx
Outdated
Show resolved
Hide resolved
fbwoolf
force-pushed
the
refactor/icons-again
branch
from
722e5e9 to
524d5e8
Compare
fbwoolf
force-pushed
the
refactor/icons-again
branch
from
524d5e8 to
1d55f2b
Compare
fbwoolf
force-pushed
the
refactor/icons-again
branch
from
c98fd61 to
4c9c532
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the icons to now use a
variantprop bc the design team does not want us to simply scale the svg. There are now two svgs fordefaultandsmallso that thestrokeWidthis accurate depending on the size. I think this is the best approach for implementing this, but open to other ideas.If a different size is needed, you can still pass a
widthprop to change the size, but the strokeWidth will scale ...which is what the design team asked for in the new issue linked here.The new
defaultsize is 24x24. We had previously been using 16x16 ('sm') as the default. So, in this PR I went thru and tried to QA changing all the icons for what seemed most accurate with our current UI. Please QA and let me know if you find any I missed if the scale is off. cc @fabric-8