chore: implement fix to limit amount of accounts rendered #5170
Conversation
pete-watters
force-pushed
the
fix/5149/virtuoso-partial
branch
from
724e604 to
c71c2cf
Compare
| @@ -43,6 +43,7 @@ export const SwitchAccountDialog = memo(({ isShowing, onClose }: DialogProps) => | |||
| if (!isShowing) return null; | |||
|
|
|||
| const accountNum = stacksAddressesNum || btcAddressesNum; | |||
| const maxAccountsShown = accountNum > 10 ? 10 : accountNum; | |||
There was a problem hiding this comment.
@kyranjamie - you were right about this and I had naively set the list to have a generated height based on all of the accounts. This change limits it to only allow the height of 10 accounts to be rendered.
When I test I still see more than 10 rendered so I need to figure that out. I see 15 items rendered when I can only see 9 in the viewport.
The reason I changed this code was so that the UI could smoothly adjust and increase the list height on smaller width screens. Adding this code impacts that but I am close to having a better fix in: #5171
I just thought it best to get something mergeable for this as it was a bad bug on dev and a release blocker
If we don't set the height it just renders an empty list so we don't see anything. I'm close to having something good and auto sizing in https://github.com/leather-wallet/extension/pull/5171/files , I just need to test it a bit better. I will check if there is a cleaner way with dynamic heights on their docs |
|
Do we expect the following sort of report to be resolved by this PR? 
|
No, thats a separate problem. This fix relates to loading all of the accounts at once in the account selector and hadn't been released to production yet. |
|
@alter-eggo are you working on this other problem (see comment above) already via other issues, or do we need to capture as a new issue? |
|
@markmhendrickson there is skeleton loader now on dev instead of 0 balance |
This PR makes a small change to fix #5149.
This fixes the issue and reduces the impact of the bug however it means that the UI isn't as slick as it could be and the list height doesn't dynamically update on narrower viewports.
I am close to having a full solution in this PR but thought it worth improving what we have on
devwhile I am finalising that.Here's what I am talking about:
Area.mp4