Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: ensure all checks pass #6134

Merged
merged 1 commit into from
Feb 21, 2025
Merged

ci: ensure all checks pass #6134

merged 1 commit into from
Feb 21, 2025

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented Feb 21, 2025 •
edited
Loading

Try out Leather build 129df46 — Extension build, Test report, Storybook, Chromatic

This CI change sets a single action that groups the result of all others, such that our branch rules can state a single rule that must pass before merging.

This should prevent very naughty merges of failed builds.

Before After
image image

@kyranjamie kyranjamie requested a review from alexp3y February 21, 2025 12:15
alexp3y
alexp3y approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@alexp3y alexp3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Child-proofing complete 😄 🙏 I like that this gives us a nice top-level checks summary as well.

@kyranjamie kyranjamie merged commit e7f9db4 into dev Feb 21, 2025
33 checks passed
@kyranjamie kyranjamie deleted the ci/all-checks-pass branch February 21, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexp3y alexp3y alexp3y approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyranjamie @alexp3y