Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CD: Fastlane setup #837

Closed
wants to merge 14 commits into from
Closed

Conversation

pete-watters
Copy link
Contributor

No description provided.

Copy link

linear bot commented Jan 29, 2025

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.09%. Comparing base (16d97bd) to head (275d647).
Report is 18 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #837   +/-   ##
=======================================
  Coverage   40.09%   40.09%           
=======================================
  Files         207      207           
  Lines        9651     9651           
  Branches      567      567           
=======================================
  Hits         3870     3870           
  Misses       5781     5781           
Components Coverage Δ
bitcoin 64.15% <ø> (ø)
query 12.60% <ø> (ø)
utils 83.23% <ø> (ø)
crypto 68.21% <ø> (ø)
stacks 71.78% <ø> (ø)

@pete-watters pete-watters force-pushed the chore/LEA-1844/life-in-the-fastlane branch from ce785f3 to 385321b Compare January 29, 2025 11:10
@@ -0,0 +1,74 @@
name: iOS Development Build
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camerow you can ignore this action. It's just doing a direct deploy to firebase

They could be useful as a reference for runs-on: macos-latest etc. as this works with doing eas build then deploy to firebase

with:
name: app-release
path: ${{ github.workspace }}/app-release.apk
# - name: Run Release Please
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camerow here I was getting the release notes from release-please but its taking them for all the differences between main and dev, of which there are way too many. This is why lots of tickets got re-opened also

storePassword 'android'
keyAlias 'androiddebugkey'
keyPassword 'android'
// if (project.hasProperty('LEATHER_UPLOAD_STORE_FILE')) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camerow on the hackathon, it wouldn't work until I disabled if (project.hasProperty('LEATHER_UPLOAD_STORE_FILE') then I just copied in the debug.keystore etc. to get it working locally but I think thats not correct (although working)

@pete-watters
Copy link
Contributor Author

Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant