feat: init web app, LEA-2115 #865
Open
+3,032
−284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #865 +/- ##
=======================================
Coverage 40.06% 40.06%
=======================================
Files 203 203
Lines 9689 9689
Branches 575 575
=======================================
Hits 3882 3882
Misses 5807 5807
|
alter-eggo
force-pushed
the
feat/init-web-app
branch
6 times, most recently
from
7cdd37e to
d6ed2f0
Compare
kyranjamie
reviewed
Feb 11, 2025
apps/web/.eslintrc.cjs
Outdated
| @@ -0,0 +1,84 @@ | |||
| /** | |||
There was a problem hiding this comment.
can this be a esm module like the other packages?
apps/web/app/tailwind.css
Outdated
| @@ -0,0 +1,12 @@ | |||
| @tailwind base; | |||
There was a problem hiding this comment.
Saw your comment on doing this another time, but for removing code, suggest we remove this in this PR, so it never enters the history
camerow
reviewed
Feb 11, 2025
apps/web/README.md
Outdated
| @@ -0,0 +1,47 @@ | |||
| # Welcome to Remix + Cloudflare! | |||
There was a problem hiding this comment.
Would be nice to commit a basic version of our own readme here - describe the app, present it to the community at large and describe what we are doing here.
camerow
reviewed
Feb 11, 2025
| @@ -0,0 +1,36 @@ | |||
| { | |||
| "include": [ | |||
There was a problem hiding this comment.
We have:
"extends": "../../packages/tsconfig-config/tsconfig.base",
do we want to use that like in mobile?
alter-eggo
force-pushed
the
feat/init-web-app
branch
from
d6ed2f0 to
2564465
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up of new web app using https://developers.cloudflare.com/pages/framework-guides/deploy-a-remix-site/
will fix configs in sep prs