Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update certificates.md #1732

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jvanasco
Copy link
Contributor

Corrected expiry year of ISRG Root X1 on Certificates page to 2035.

Important

Corrected expiry year of ISRG Root X1 on Certificates page to 2035.
Copy link
Contributor

@mcpherrinm mcpherrinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is deliberate: it is the validity in browser root stores, which is earlier than the x509 not_after

@mcpherrinm
Copy link
Contributor

I think this has been a point of confusion a few times though, so some rewording could probably happen.

@jvanasco
Copy link
Contributor Author

I updated my comment on the discourse to read the following:

The ISRG Root X1 Certificate with a "notAfter" of 2035-06-04 is considered to expire on 2030-06-04 due to root program policies. The single Certificate has a technical validity until 2035, but will expire from root programs and usage in 2030.

The confusion to me was surfaced by this thread, in which someone noted the expiry was 2035 on crt.sh and I remembered this to be 2030.

My suggestion for a fix would probably be something like this:

- until 2030-09-04 (generated 2020-09-04)
- until 2030-09-04 (notAfter: 2035-09-04; notBefore 2020-09-04)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants