-
Notifications
You must be signed in to change notification settings - Fork 19
Add option for custom rxPin and txPin with HardwareSerial (e.g. for ESP32) #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cyberman54
wants to merge
5
commits into
lewapek:master
Choose a base branch
from
cyberman54:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
27e3196
Merge pull request #1 from lewapek/master
cyberman54 ec89ad1
Make pins configurable for HardwareSerial
cyberman54 083d74c
Make rxPin/txPin configurable by begin method
cyberman54 6d40f58
Update README.md
cyberman54 47bc356
Update README.md
cyberman54 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,16 +17,16 @@ namespace Serials { | |
// just to satisfy linker in gcc I needed to add empty parentheses to other virtual methods... | ||
class AbstractSerial { | ||
public: | ||
virtual void begin(int baudRate) = 0; | ||
virtual void begin(int baudRate, uint32_t config, int pinRx, int pinTx) = 0; | ||
virtual Stream *getStream() = 0; | ||
virtual ~AbstractSerial() {}; | ||
}; | ||
|
||
struct Hardware: public AbstractSerial { | ||
Hardware(HardwareSerial &serial): serial(serial) {} | ||
|
||
void begin(int baudRate) { | ||
serial.begin(baudRate); | ||
void begin(int baudRate = 9600, uint32_t config = SERIAL_8N1, int pinRx = -1, int pinTx = -1) { | ||
serial.begin(baudRate, config, pinRx, pinTx); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. esp32 |
||
} | ||
|
||
Stream *getStream() { | ||
|
@@ -40,7 +40,7 @@ namespace Serials { | |
struct Software: public AbstractSerial { | ||
Software(SoftwareSerial &serial): serial(serial) {} | ||
|
||
void begin(int baudRate) { | ||
void begin(int baudRate = 9600, uint32_t config = SERIAL_8N1, int pinRx = -1, int pinTx = -1) { | ||
serial.begin(baudRate); | ||
} | ||
|
||
|
@@ -61,8 +61,8 @@ namespace Serials { | |
} | ||
} | ||
|
||
void begin(int baudRate) { | ||
serial->begin(baudRate); | ||
void begin(int baudRate = 9600, uint32_t config = SERIAL_8N1, int pinRx = -1, int pinTx = -1) { | ||
serial.begin(baudRate); | ||
} | ||
|
||
Stream *getStream() { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep 2 spaces indentation to be consistent with the rest of the project