tests: change runner to a module

Chai 5 only supports ES6 modules now, so if we want to upgrade past
version 4, we have to change our test runners to modules first.

Change-Id: I4d0c8cd425b29e5692cac14af1db2757b869f5d4
Reviewed-on: https://chromium-review.googlesource.com/c/apps/libapps/+/6204313
Reviewed-by: Joel Hockey <[email protected]>
Tested-by: kokoro <[email protected]>

Author: vapier

hterm/html/hterm_test.html

@@ -8,7 +8,7 @@
     <script src='../../node_modules/mocha/mocha.js'></script>
 
     <!-- initialize the test framework; this must come first -->
-    <script src='../js/hterm_test.js'></script>
+    <script type='module' src='../js/hterm_test.js'></script>
 
     <script type='module' src='../js/hterm_tests.js'></script>
     <script type='module' src='../js/hterm_accessibility_reader_tests.js'></script>

hterm/js/hterm_test.js

@@ -2,9 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// NB: This file is not loaded as a module because it modifies global scope.
-'use strict';
-
 /**
  * @fileoverview Test framework setup when run inside the browser.
  */
@@ -14,7 +11,7 @@ mocha.setup('bdd');
 mocha.checkLeaks();
 
 // Add a global shortcut to the assert API.
-const assert = chai.assert;
+globalThis['assert'] = chai.assert;
 
 // Catch any random errors before the test runner runs.
 let earlyError = null;

libdot/externs/chai.js

@@ -25,6 +25,13 @@ chai.config;
  */
 chai.assert = function(expression, message) {};
 
+/**
+ * Shortcut that we always export in our test runner.
+ *
+ * @const
+ */
+var assert = chai.assert;
+
 /**
  * @param {*} actual
  * @param {*} expected

libdot/html/lib_test.html

@@ -8,7 +8,7 @@
     <script src='../../node_modules/mocha/mocha.js'></script>
 
     <!-- initialize the test framework; this must come first -->
-    <script src='../js/lib_test.js'></script>
+    <script type="module" src='../js/lib_test.js'></script>
 
     <!-- libdot js tests -->
     <script type='module' src='../js/lib_codec_tests.js'></script>

libdot/js/lib_test.js

@@ -2,9 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// NB: This file is not loaded as a module because it modifies global scope.
-'use strict';
-
 /**
  * @fileoverview Test framework setup when run inside the browser.
  */
@@ -14,7 +11,7 @@ mocha.setup('bdd');
 mocha.checkLeaks();
 
 // Add a global shortcut to the assert API.
-const assert = chai.assert;
+globalThis['assert'] = chai.assert;
 
 // Catch any random errors before the test runner runs.
 let earlyError = null;

nassh/html/nassh_test.html

@@ -8,7 +8,7 @@
     <script src='../../node_modules/mocha/mocha.js'></script>
 
     <!-- initialize the test framework; this must come first -->
-    <script src='../js/nassh_test.js'></script>
+    <script type='module' src='../js/nassh_test.js'></script>
     <script src='../js/chrome_mock_for_test.js'></script>
 
     <!-- All the unittests go below here. -->

nassh/js/nassh_test.js

@@ -2,9 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// NB: This file is not loaded as a module because it modifies global scope.
-'use strict';
-
 /**
  * @fileoverview Test framework setup when run inside the browser.
  */
@@ -14,7 +11,7 @@ mocha.setup('bdd');
 mocha.checkLeaks();
 
 // Add a global shortcut to the assert API.
-const assert = chai.assert;
+globalThis['assert'] = chai.assert;
 
 // Catch any random errors before the test runner runs.
 let earlyError = null;

terminal/js/terminal_test_preload.js

@@ -2,11 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-'use strict';
-
 /**
  * @fileoverview Test framework setup when run inside the browser.
  */
 
 // Add a global shortcut to the assert API.
-const assert = chai.assert;
+globalThis['assert'] = chai.assert;

wasi-js-bindings/test/index.html

@@ -8,7 +8,7 @@
     <script src='../../node_modules/mocha/mocha.js'></script>
 
     <!-- Initialize the test framework; this must come first. -->
-    <script src='runner.js'></script>
+    <script type='module' src='runner.js'></script>
 
     <!-- All the test modules. -->
     <script type='module' src='argv.js'></script>

wasi-js-bindings/test/runner.js

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-'use strict';
-
 /**
  * @fileoverview WASI main test runner.
  */
@@ -18,7 +16,7 @@ chai.config.showDiff = true;
 chai.config.truncateThreshold = 0;
 
 // Add a global shortcut to the assert API.
-const assert = chai.assert;
+globalThis['assert'] = chai.assert;
 
 // Catch any random errors before the test runner runs.
 let earlyError = null;