libbpf-cargo: Make all XXX_data skeleton members optional #1162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 27dfe16 "libbpf-cargo: Don't provide kconfig data access after "open"" worked around the fact that the kconfig data member may not be present whenever. As it turns out, there is no guarantee that any of the data members are available as memory mapped data: on older kernels that "do not support memory-mapped global variable maps, libbpf will just avoid doing mmap" [0]. Revert this special sauce work around, as that means it's basically unnecessary now and we have to come up with a generic solution instead. This reverts commit 27dfe16. [0]: libbpf#1151 (comment) Signed-off-by: Daniel Müller <[email protected]>
As discussed in libbpf#1151, libbpf may not provide direct memory map access to any of the BPF map members if the kernel does not support memory-mapped global variable maps. To that end, make them all optional. Closes: libbpf#1151 Signed-off-by: Daniel Müller <[email protected]>
d-e-s-o
force-pushed
the
topic/opt-mmap-maps
branch
from
d244e61 to
cc819a0
Compare
d-e-s-o
force-pushed
the
topic/opt-mmap-maps
branch
2 times, most recently
from
40f685f to
6ea7be7
Compare
anakryiko
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commits for descriptions.