fix TXT record not wrapped in quotes

[mercury233]

According to the doc of Cloudflare, quotation marks is required for TXT record.
https://www.cloudflare.com/learning/dns/dns-records/dns-txt-record/

fix caddy-dns/cloudflare#89

[mercury233]

Known problem: Can't cleanup the TXT record after success, due to s.records here have quoted value but keyAuth don't.
https://github.com/caddyserver/certmagic/blob/32654015b016c876b02dd881323e3303cd10f770/solvers.go#L315
https://github.com/caddyserver/certmagic/blob/32654015b016c876b02dd881323e3303cd10f770/solvers.go#L544

[mholt]

Thanks for the PR.

However, this has never been necessary before, why is it now? 🤔

Cloudflare's docs state that they will automatically add quotes if missing:

For new records, if you save your TXT content without any quotes, Cloudflare will automatically add double quotes.

Is that wrong?

[mercury233]

As you can see in caddy-dns/cloudflare#89 , Cloudflare stop adding quotes.
And the docs look like it is a feature avail only in dashboard now.

[mholt]

Hmm, yeah, I've seen that issue, but the evidence is only someone saying "it seems" -- I'm looking for actual documentation. That changelog is interesting, but as you said, doesn't seem to apply to the API. I'm confused if Cloudflare would actually roll out a breaking change like that with seemingly no documentation?

Anyway, I'm fine with this change (though I'll have a suggestion for a revision before we merge it) -- but I do want to understand what happened first. This plugin has worked for years. Why did it suddenly break? Did Cloudflare really break their API? If so, where's the docs?

[mercury233]

I can't find more documents from CF too, but I saw some complaints about forcefully adding quotes recently in the CF community.

BTW, I did a test again just now, and Caddy (official build) managed to obtain the cert, it seems CF has made some changes again.

[mholt]

Thanks for looking into it!

BTW, I did a test again just now, and Caddy (official build) managed to obtain the cert, it seems CF has made some changes again.

I'm just not convinced that Cloudflare is changing things around willy-nilly with their API like this. Maybe they are, and they're breaking things, and that sucks...

I think something else is going on. But I really want to understand what it is before changing a package that has been working steadily for years.