Skip to content

GenerateNativeDll task: use file name from nuget #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2015
Merged

Conversation

ethomson
Copy link
Member

Use the libgit2_filename.txt from the NuGet package instead of
trying to derive it based on the hash.

Depends on libgit2/libgit2sharp.nativebinaries#17

@shiftkey
Copy link
Contributor

System.TypeInitializationException: The type initializer for 'LibGit2Sharp.Core.NativeMethods' threw an exception. ---> System.DllNotFoundException: Unable to load DLL '4d6362b168cdbc7d5b734810f2c81020c2837c4a': The specified module could not be found. (Exception from HRESULT: 0x8007007E)

Hrm

@bording
Copy link
Member

bording commented Jul 16, 2015

Taking a quick look at this, I'm not sure it's going to work correctly yet. Did you look at the NativeDllName.targets file? The file that is being passed to the task there is the hash file. You'll also need to change that to point to your new ``libgit2_filename.txt` file.

@ethomson
Copy link
Member Author

Did you look at the NativeDllName.targets file?

Yeah, I neglected to include that change. Thanks!

@nulltoken
Copy link
Member

@ethomson Rebased. What should we do with this PR?

Use the `libgit2_filename.txt` from the NuGet package instead of
trying to derive it based on the hash.
@ethomson
Copy link
Member Author

Any reason not to merge it?

@nulltoken
Copy link
Member

Any reason not to merge it?

The build was previously failing. I've just fixed it 😉

nulltoken added a commit that referenced this pull request Aug 23, 2015
GenerateNativeDll task: use file name from nuget
@nulltoken nulltoken merged commit 7e2c42d into vNext Aug 23, 2015
@nulltoken nulltoken deleted the custom_dllname branch August 23, 2015 14:09
@nulltoken nulltoken added this to the v0.22 milestone Aug 23, 2015
@ethomson
Copy link
Member Author

✨ Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants