LedDialog: fix buggy effect duration slider #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get the step increment from the Gtk.Adjustment instead of relying on a magic number (500), which was wrong to begin with (actual value is 100). Round the received float value to the nearest multiple of the step increment, instead of rounding it down. This fixes control of the slider through the arrow keys and improves the accuracy of the "step snapping" when clicking the slider. As a result, the UI now allows the user to pass values with a step (100) instead of page (500) resolution to libratbag but that shouldn't be an issue as drivers are expected to support any integer value within the range 0-10000; see ratbag_led_set_effect_duration().
staticssleever668
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Thanks! Tested and it's working nice.
As a note, the step increment seems to be defined here:
Lines 10 to 14 in 71431bd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the step increment from the Gtk.Adjustment instead of relying on a magic number (500), which was wrong to begin with (actual value is 100).
Round the received float value to the nearest multiple of the step increment, instead of rounding it down.
This fixes control of the slider through the arrow keys and improves the accuracy of the "step snapping" when clicking the slider.
As a result, the UI now allows the user to pass values with a step (100) instead of page (500) resolution to libratbag but that shouldn't be an issue as drivers are expected to support any integer value within the range 0-10000; see ratbag_led_set_effect_duration().