Skip to content

Restore DBD:mysql to URI::mysql #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Restore DBD:mysql to URI::mysql #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
Revision history for Perl extension URI::db.

0.24
- Changed the URI::mysql `dbi_dsn()` back to use the DBD::mysql driver.
URI::mariadb, however, still uses DBD::MariaDB. Thanks to Alastair
Douglas for the completely reasonable gripe (#29).

0.23 2025-01-09T02:48:06Z
- Added URI::clickhouse. Thanks to Ilia Rassadin for the PR (#18).
Expand Down
2 changes: 2 additions & 0 deletions lib/URI/mariadb.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@ package URI::mariadb;
use base 'URI::mysql';
our $VERSION = '0.24';

sub dbi_driver { 'MariaDB' }

1;
2 changes: 1 addition & 1 deletion lib/URI/mysql.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use base 'URI::_db';
our $VERSION = '0.24';

sub default_port { 3306 }
sub dbi_driver { 'MariaDB' }
sub dbi_driver { 'mysql' }
sub canonical_engine { 'mysql' }

sub _dbi_param_map {
Expand Down
2 changes: 1 addition & 1 deletion t/dbi.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ for my $spec (
},
{
uri => 'db:mysql://localhost:33/foo',
dsn => 'dbi:MariaDB:host=localhost;port=33;database=foo',
dsn => 'dbi:mysql:host=localhost;port=33;database=foo',
dbi => [ [host => 'localhost'], [port => 33], [database => 'foo'] ],
qry => [],
},
Expand Down
Loading