Skip to content

Permit passing an empty or false value to second param (value) of tick(). #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Permit passing an empty or false value to second param (value) of tick(). #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb6502e
Permit passing an empty or false value to second param (value) of
jmadler Apr 16, 2011
f05597b
Documentation did not accurately reflect change in previous revision
jmadler Apr 16, 2011
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions lib/WWW/Mechanize.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1611,9 +1611,12 @@ sub set_visible {
=head2 $mech->tick( $name, $value [, $set] )

"Ticks" the first checkbox that has both the name and value associated
with it on the current form. Dies if there is no named check box for
that value. Passing in a false value as the third optional argument
will cause the checkbox to be unticked.
with it on the current form. If there is no value to the input, just
pass an empty string as the value. Dies if there is no named checkbox
for the value given, if a value is given. Passing in a false value
as the third optional argument will cause the checkbox to be unticked.
The third value does not need to be set if you wish to merely tick the
box.

=cut

Expand All @@ -1626,6 +1629,13 @@ sub tick {
# loop though all the inputs
my $index = 0;
while ( my $input = $self->current_form->find_input( $name, 'checkbox', $index ) ) {
# Sometimes the HTML is malformed and there is no value for the check
# box, so we just return if the value passed is an empty string
# (and the form input is found)
if ($value eq '') {
$input->value($set ? $value : undef);
return;
}
# Can't guarantee that the first element will be undef and the second
# element will be the right name
foreach my $val ($input->possible_values()) {
Expand Down