image hosting part 1 #18378
Open
image hosting part 1 #18378
+2,142
−1,035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ornicar
reviewed
Oct 11, 2025
ornicar
reviewed
Oct 11, 2025
|
what about profile? do you want image in bio via markdown, a dedicated image form like streamer, or leave it alone? |
|
We leave profile as is for now. When adding an image upload for it we have to think about the profile page design, as the image dimensions will cement it. |
|
Off to a good start, I think. Marking as draft until it has moderation tools. |
- ui.bits remains static and lean - callers don't have any added boilerplate - markdownTextarea can never fail due to a missing mutable config
Every module depends on lila.memo so we don't need the core trait
Everything in PicfitImage is metadata. The only reason why dimensions
and context were grouped are because they come from the client as form
data.
So I made a form data class instead and removed that grouping from the
rest of the code.
```js
db.picfit_image.updateMany({'meta.context':{$exists:1}},{$rename:{'meta.context':'context'}})
db.picfit_image.updateMany({'meta.dim':{$exists:1}},{$rename:{'meta.dim':'dimensions'}})
```
ornicar
reviewed
Oct 19, 2025
ornicar
reviewed
Oct 19, 2025
at least, it no longer knows that it does it :-/
|
markdown doesn't look great in user activity timeline: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add markdown to forums. add image hosting with upload/resizing in all markdown & toast forms.
fix #18322