Game setup redesign [RFC] #18913
Draft
Game setup redesign [RFC] #18913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dav1312
force-pushed
the
game-setup-rfc
branch
from
02856ee to
7b7fb17
Compare
dav1312
force-pushed
the
game-setup-rfc
branch
from
7b7fb17 to
079f415
Compare
as it is the most popular and well-known variant
Collaborator
|
Looking really good. |
Because many players use the setup dialog instead of the pool buttons, either to set rating limits (unnecessarily) or just out of habbit. They would miss the standard TCs if not included there. Also we should encourage setup players to use the pool TCs to improve matchmaking quality.
Collaborator
we could highlight the currently selected TC button (if any) |
Collaborator
|
Collaborator
|
Contributor
Author
|
BTW the reason I had two sets of presets was so that if a player chose "Custom", to not present him with the same presets that they already had in the main page but instead with other popular TCs |
Collaborator
|
Collaborator
I see. |
already removed in master
we already get them from the server on page load
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on this for over a week so I think its time for a RFC
This would be my biggest change yet and I'm still new to the codebase so I would like some comments about it in case there are things that I should've done differently
Closes #18585