Skip to content

Commit

Permalink
chore: fix tests
Browse files Browse the repository at this point in the history
  • Loading branch information
tamtamchik committed Feb 5, 2025
1 parent 6722576 commit 8c1a908
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 6 deletions.
4 changes: 2 additions & 2 deletions contracts/0.8.25/vaults/VaultHub.sol
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ abstract contract VaultHub is PausableUntilWithRoles {

IStakingVault(_vault).forceValidatorWithdrawal{value: msg.value}(_pubkeys);

emit ForceValidatorWithdrawalRequested(_vault, _pubkeys);
emit VaultForceWithdrawalInitiated(_vault, _pubkeys);
}

function _disconnect(address _vault) internal {
Expand Down Expand Up @@ -528,7 +528,7 @@ abstract contract VaultHub is PausableUntilWithRoles {
event BurnedSharesOnVault(address indexed vault, uint256 amountOfShares);
event VaultRebalanced(address indexed vault, uint256 sharesBurned);
event VaultProxyCodehashAdded(bytes32 indexed codehash);
event ForceValidatorWithdrawalRequested(address indexed vault, bytes pubkeys);
event VaultForceWithdrawalInitiated(address indexed vault, bytes pubkeys);

error StETHMintFailed(address vault);
error AlreadyBalanced(address vault, uint256 mintedShares, uint256 rebalancingThresholdInShares);
Expand Down
3 changes: 3 additions & 0 deletions test/0.8.25/vaults/delegation/delegation.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ describe("Delegation.sol", () => {
let depositPauser: HardhatEthersSigner;
let depositResumer: HardhatEthersSigner;
let exitRequester: HardhatEthersSigner;
let withdrawalInitiator: HardhatEthersSigner;
let disconnecter: HardhatEthersSigner;
let curator: HardhatEthersSigner;
let nodeOperatorManager: HardhatEthersSigner;
Expand Down Expand Up @@ -71,6 +72,7 @@ describe("Delegation.sol", () => {
depositPauser,
depositResumer,
exitRequester,
withdrawalInitiator,
disconnecter,
curator,
nodeOperatorManager,
Expand Down Expand Up @@ -113,6 +115,7 @@ describe("Delegation.sol", () => {
depositPauser,
depositResumer,
exitRequester,
withdrawalInitiator,
disconnecter,
curator,
nodeOperatorManager,
Expand Down
4 changes: 1 addition & 3 deletions test/0.8.25/vaults/staking-vault/stakingVault.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -703,9 +703,7 @@ describe("StakingVault.sol", () => {

await expect(stakingVault.connect(vaultHubSigner).forceValidatorWithdrawal(SAMPLE_PUBKEY, { value: fee }))
.to.emit(stakingVault, "FullWithdrawalInitiated")
.withArgs(vaultHubSigner, SAMPLE_PUBKEY)
.and.to.emit(stakingVault, "ForceValidatorWithdrawal")
.withArgs(SAMPLE_PUBKEY);
.withArgs(vaultHubSigner, SAMPLE_PUBKEY);
});
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ describe("VaultHub.sol:forceWithdrawals", () => {

it("initiates force validator withdrawal", async () => {
await expect(vaultHub.forceValidatorWithdrawal(vaultAddress, SAMPLE_PUBKEY, { value: FEE }))
.to.emit(vaultHub, "ForceValidatorWithdrawalRequested")
.to.emit(vaultHub, "VaultForceWithdrawalInitiated")
.withArgs(vaultAddress, SAMPLE_PUBKEY);
});
});
Expand Down
1 change: 1 addition & 0 deletions test/integration/vaults-happy-path.integration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ describe("Scenario: Staking Vaults Happy Path", () => {
depositPauser: curator,
depositResumer: curator,
exitRequester: curator,
withdrawalInitiator: curator,
disconnecter: curator,
nodeOperatorManager: nodeOperator,
nodeOperatorFeeClaimer: nodeOperator,
Expand Down

0 comments on commit 8c1a908

Please sign in to comment.