test: vaults fuzzing #918
Draft
test: vaults fuzzing #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: e9a302d Minimum allowed coverage is ♻️ This comment has been updated with latest results |
tamtamchik
reviewed
Jan 13, 2025
tamtamchik
force-pushed
the
feat/vaults-fuzzing-share-rate
branch
from
1d41029 to
7d05ee2
Compare
tamtamchik
reviewed
Feb 2, 2025
| * forge-config: default.invariant.depth = 256 | ||
| * forge-config: default.invariant.fail-on-revert = true | ||
| */ | ||
| function invariant_totalShares() public view { |
There was a problem hiding this comment.
💡 Maybe add an invariant that lido.getExternalShares = startExternalBalance + mintedExternal - burnedExternal? So we'll know it something is odd inside a math for external shares?
| // if (_report.timestamp >= block.timestamp) revert IncorrectReportTimestamp(_report.timestamp, block.timestamp); | ||
| vm.warp(_timestamp + 1); | ||
|
|
||
| fuzz._lidoExecutionLayerRewardVaultWei = bound(fuzz._lidoExecutionLayerRewardVaultWei, 0, 1_000) * 1 ether; |
There was a problem hiding this comment.
Providing comments on why the bounding appears as it does would be helpful during reviews and test updates.
| } | ||
|
|
||
| contract AccountingHandler is CommonBase, StdCheats, StdUtils { | ||
| struct Ghost { |
There was a problem hiding this comment.
💡 Maybe add a boundary holder to track minimum and maximum values used in all the runs, so we can review them after the test and ensure we're not missing any potential values chunks?
There was a problem hiding this comment.
Added in e9a302d. Shows the max <> min range.. Like this:
Boundary Values:
PreClValidators min: 250000
PreClValidators max: 100000000000
ClValidators min: 259381
ClValidators max: 100000043199
ClBalanceWei min: 8300705805470639196490834
ClBalanceWei max: 3200271341074368560000000000000
DepositedValidators min: 293200
DepositedValidators max: 100000086397
ElRewardsVaultBalanceWei min: 0
ElRewardsVaultBalanceWei max: 977277467356288757093
…zzing-share-rate # Conflicts: # package.json # test/0.4.24/contracts/StakingRouter__MockForLidoAccounting.sol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test shareRate with fuzzing