define the scala 2 macros in the scala 3 module #415
Conversation
johnduffell
changed the title
build.sbt
Outdated
| ) | ||
| incOptions := incOptions.value.withLogRecompileOnMacro(false) | ||
| val scala213 = "2.13.12" | ||
| val scala3 = "3.4.0-RC1-bin-20231016-69e1338-NIGHTLY" //TODO 3.3.2 or 3.4.0 |
There was a problem hiding this comment.
once a release includes scala/scala3#18663 we can bump this, retest and release
| @@ -0,0 +1,85 @@ | |||
| package com.typesafe.scalalogging | |||
There was a problem hiding this comment.
this file is essentially a rename, with minor changes Scala2LoggerMacro to avoid a name clash
| inline def trace(inline marker: Marker, inline message: String, inline args: Any*): Unit = ${LoggerMacro.traceMessageArgsMarker('underlying, 'marker, 'message, 'args)} | ||
| inline def whenTraceEnabled(inline body: Unit): Unit = ${LoggerMacro.traceCode('underlying, 'body)} | ||
|
|
||
| //scala 2 |
There was a problem hiding this comment.
the rest is a copy of the scala 2 macro definitions to be compiled in scala 3. Then these can be used from either scala 3 or 2.
| private[scalalogging] object Scala2LoggerMacro { | ||
|
|
||
| type LoggerContext = blackbox.Context { type PrefixType = Logger } | ||
| type LoggerContext = blackbox.Context |
There was a problem hiding this comment.
this was not needed, and it made a cyclical dependency
| private[scalalogging] object Scala2LoggerTakingImplicitMacro { | ||
|
|
||
| type LoggerContext[A] = blackbox.Context { type PrefixType = LoggerTakingImplicit[A] } | ||
| type LoggerContext[A] = blackbox.Context |
There was a problem hiding this comment.
this was not needed, and it made a cyclical dependency
SethTisue
changed the title
|
3.3.2 and 3.4.0 are on Maven Central (and will be announced once tooling support lands) |
|
thanks @SethTisue - I don't believe the fix has been backported to 3.3.2, I think it's likely to end up in 3.3.3 instead. I have updated the PR to 3.4.0 which does have the fix, but I wonder if we prefer to target latest LTS as per this recommendation? https://www.scala-lang.org/blog/2022/08/17/long-term-compatibility-plans.html#library-maintainers |
Yes, if it all possible, though it hurts in this case. Fingers crossed 3.3.3 comes along before too much longer. I suppose one possibility would be to publish a milestone that requires 3.4, then wait for the fix to land in LTS before doing a final release. |
2 participants
This PR is a preview of a fix for #317
It needs the fix from scala/scala3#18663 which is in scala 3.4.0 release (and hopefully 3.3.3) in order to compile without an error
Something's wrong: missing original symbol for type treeIt is a fresh implementation although along the same lines at this demonstration PR #350 by @srollins-lucid
It could probably do with some more tests - the current tests show that everything (still) works in all supported versions, but we could add some tests to make sure it works as intended from scala 2 and 3 with the scala 3 dependency only, as per https://docs.scala-lang.org/scala3/guides/migration/tutorial-macro-mixing.html
SBT is probably my weakest point, so I'm happy to believe that I've somehow broken the cross build or the release process during my hacking, so feedback or updates would be appreciated.