Refactor litclient and perms to reduce LNC dependencies #1057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved jsoncallbacks.go into the litrpc package, allowing Lightning Node Connect to stop importing the litclient package. This change avoids pulling in the rest of lit and taproot-assets, as litclient was not a separate module. The now-empty litclient directory has also been removed.
Updated the LND version in litrpc to align with the version used in the parent module, ensuring consistency across dependencies.
Converted the perms package into its own module to prevent Lightning Node Connect from importing the entire lit repo, which includes taproot-assets. This change avoids exhausting symbol limits in the LNC WASM client due to unnecessary transitive dependencies.
bhandras
approved these changes
May 2, 2025
guggero
approved these changes
May 5, 2025
| @@ -0,0 +1,190 @@ | |||
| module github.com/lightninglabs/lightning-terminal/perms | |||
There was a problem hiding this comment.
Another option would be to just move this into the litrpc package, to avoid needing yet another submodule. But not sure if it fits there 100% content/topic wise. So just a thought.
| @@ -21,6 +21,7 @@ require ( | |||
| github.com/lightninglabs/lightning-node-connect v0.3.3-alpha.0.20250306111457-cad4234830cc | |||
| github.com/lightninglabs/lightning-terminal/autopilotserverrpc v0.0.2 | |||
| github.com/lightninglabs/lightning-terminal/litrpc v1.0.1 | |||
| github.com/lightninglabs/lightning-terminal/perms v1.0.1 | |||
There was a problem hiding this comment.
This should probably be v1.0.0, as it's the first version. I only needed to bump litrpc to v1.0.1 because the go sum proxy somehow cached that the v1.0.0 didn't exist yet (probably just needed to wait a bit but was impatient).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: lightninglabs/lightning-node-connect#113
permsinto a standalone module to limitlncdependencies.jsoncallbacks.gointolitrpcto reducelncimport scope.lndversion inlitrpcto match parent module.